Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: expect coerce functions to be synchronous #47

Merged
merged 1 commit into from
Aug 9, 2016
Merged

refactor: expect coerce functions to be synchronous #47

merged 1 commit into from
Aug 9, 2016

Conversation

nexdrew
Copy link
Member

@nexdrew nexdrew commented Aug 8, 2016

Expect a coercion function to return or throw instead of calling a callback, to avoid any ambiguity that async functions might be supported.

@nexdrew nexdrew mentioned this pull request Aug 8, 2016
Merged
@bcoe
Copy link
Member

bcoe commented Aug 8, 2016

@nexdrew I like this API much better.

@bcoe bcoe merged commit 487fecf into master Aug 9, 2016
@bcoe bcoe deleted the sync-coerce-api branch August 9, 2016 04:39
@maxrimue maxrimue mentioned this pull request Aug 9, 2016
Closed
10 tasks
@nexdrew nexdrew mentioned this pull request Aug 13, 2016
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nexdrew @bcoe